Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use notification box for reverse geocoding #307

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Use notification box for reverse geocoding #307

merged 1 commit into from
Jun 3, 2024

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented Jun 2, 2024

Fixes #304

Changes proposed in this pull request:

  • Use notification box for reverse geocoding

@dkastl dkastl requested review from smellman and sanak June 3, 2024 10:18
@sanak sanak mentioned this pull request Jun 3, 2024
Merged
sanak
sanak approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I confirmed that PC Chrome shows clipboard comment, and iPhone Safari and Android Chrome show reverse geocoded address text.

@dkastl dkastl merged commit 96b22b9 into next Jun 3, 2024
10 checks passed
@dkastl dkastl deleted the dkastl/issue304 branch June 3, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanak sanak sanak approved these changes

@smellman smellman Awaiting requested review from smellman

Assignees
No one assigned
Labels
None yet
Projects
Release v5.x
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkastl @sanak