Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds measure control and hover info #308

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Adds measure control and hover info #308

merged 8 commits into from
Jun 3, 2024

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented Jun 3, 2024

Fixes #305 .

Changes proposed in this pull request:

  • Add measure contro
  • Add an option to plugin settings to enable/disable this control
  • Show measurement result in notification box
  • Show measurement info as hover interaction

@dkastl
Adds permalink control
7cea6e5 
Fixes #12

Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Target cross control
43d460b 
Fixes #300

Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Fixes radius
73cd920 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Merge branch 'next' into dkastl/issue300
3864ee6 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Moves plugin settings to 3rd block
1d7e0d7 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Adjust the radius and stroke width for high DPI devices
6814209 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Add measure tooltip control
4005d8c 
Fixes #305

Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Adds hover info
24f65a9 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl dkastl requested review from sanak and smellman June 3, 2024 09:36
sanak
sanak approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I confirmed that PC Chrome shows clipboard comment, and iPhone Safari and Android Chrome show reverse geocoded address text.

@sanak
Copy link
Member

sanak commented Jun 3, 2024

Thanks! I confirmed that PC Chrome shows clipboard comment, and iPhone Safari and Android Chrome show reverse geocoded address text.

Oops, I missed to approve wrong one (#307).
Wait for a while in this side. 🙇

@dkastl dkastl merged commit 9a5152b into next Jun 3, 2024
10 checks passed
@dkastl dkastl deleted the dkastl/issue305 branch June 3, 2024 11:28
@sanak
Copy link
Member

sanak commented Jun 3, 2024

Okay, I confirmed that followings. 😊

  • Show line/polygon length/area when hovering in view mode
  • Draw line/polygon current lengh/area in editing mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanak sanak sanak approved these changes

@smellman smellman Awaiting requested review from smellman

Assignees
No one assigned
Labels
None yet
Projects
Release v5.x
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkastl @sanak