crud club tarea 1 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a simple session storage on files, making session persistent across restarts
add configuration for session storage with 1 week life for sessions add session folder to git ignore add ignore files by nodemon to ignore newly created session files
Exposed by adding an ID to the button, this way is reachable by cypress
add username used in tests as constant add base url for tests access
split into different describes to configure with independent beforeEach, usefull for testing login on one block and automatizing login on the other
add modal appear delay constant
Extend scope to global (previously local to describe block) to be reachable by other describe blocks
this test uses a random string to update all parameters then checks all names updated correctly after reloading the page
this test updates the name of the first team with a random string, then resets it and checks the name isn't the random string
all redirects where sending a 301, meaning it's a permanent redirect, but the redirects where temporal, mostly related to session and user login all redirects where replaced with 302 code, meaning it is temporal
hide all edit and remove buttons when editing a player show all input fields of the player show apply button on the player
remove specificity when requiring table's row's cells, use jquery instead of going for specific cell number, increasing robustness add cell iteration to handle rows with multiple spans and inputs (usefull for players table)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crud club 1.0
Create, Read, Update, Delete
teams and players