Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickfirst: Register a health listener when used as a leaf policy #7832

Merged
merged 11 commits into from
Dec 5, 2024

Address review comment

886ad2f
Select commit
Loading
Failed to load commit list.
Merged

pickfirst: Register a health listener when used as a leaf policy #7832

Address review comment
886ad2f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 5, 2024 in 0s

81.52% of diff hit (target 81.84%)

View this Pull Request on Codecov

81.52% of diff hit (target 81.84%)

Annotations

Check warning on line 611 in balancer/pickfirst/pickfirstleaf/pickfirstleaf.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer/pickfirst/pickfirstleaf/pickfirstleaf.go#L608-L611

Added lines #L608 - L611 were not covered by tests

Check warning on line 615 in balancer/pickfirst/pickfirstleaf/pickfirstleaf.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer/pickfirst/pickfirstleaf/pickfirstleaf.go#L614-L615

Added lines #L614 - L615 were not covered by tests

Check warning on line 626 in balancer/pickfirst/pickfirstleaf/pickfirstleaf.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer/pickfirst/pickfirstleaf/pickfirstleaf.go#L625-L626

Added lines #L625 - L626 were not covered by tests

Check warning on line 659 in balancer/pickfirst/pickfirstleaf/pickfirstleaf.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer/pickfirst/pickfirstleaf/pickfirstleaf.go#L659

Added line #L659 was not covered by tests

Check warning on line 751 in balancer/pickfirst/pickfirstleaf/pickfirstleaf.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer/pickfirst/pickfirstleaf/pickfirstleaf.go#L751

Added line #L751 was not covered by tests

Check warning on line 769 in balancer/pickfirst/pickfirstleaf/pickfirstleaf.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer/pickfirst/pickfirstleaf/pickfirstleaf.go#L768-L769

Added lines #L768 - L769 were not covered by tests

Check warning on line 788 in balancer/pickfirst/pickfirstleaf/pickfirstleaf.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer/pickfirst/pickfirstleaf/pickfirstleaf.go#L787-L788

Added lines #L787 - L788 were not covered by tests