Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickfirst: Register a health listener when used as a leaf policy #7832

Merged
merged 11 commits into from
Dec 5, 2024

Address review comment

886ad2f
Select commit
Loading
Failed to load commit list.
Merged

pickfirst: Register a health listener when used as a leaf policy #7832

Address review comment
886ad2f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 1s

82.08% (+0.23%) compared to 4c07bca

View this Pull Request on Codecov

82.08% (+0.23%) compared to 4c07bca

Details

Codecov Report

Attention: Patch coverage is 81.52174% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.08%. Comparing base (4c07bca) to head (886ad2f).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
balancer/pickfirst/pickfirstleaf/pickfirstleaf.go 81.52% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7832      +/-   ##
==========================================
+ Coverage   81.84%   82.08%   +0.23%     
==========================================
  Files         377      377              
  Lines       38120    38179      +59     
==========================================
+ Hits        31201    31339     +138     
+ Misses       5603     5541      -62     
+ Partials     1316     1299      -17     
Files with missing lines Coverage Δ
balancer/pickfirst/pickfirstleaf/pickfirstleaf.go 86.62% <81.52%> (-1.18%) ⬇️

... and 34 files with indirect coverage changes