-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated logging towards GRiSP.io #18
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
66a461c
Add log handler
ziopio 784846d
Add send_log loop to the client
ziopio 5deede1
Fix disconnection call
ziopio df56ddf
Add stage.grisp.io domain IP
ziopio 70d0e4e
Mention new app options in README
ziopio 3aa008b
Remove debug print
ziopio 706843e
Make logs related setting general
ziopio 578037d
Add edoc description to logs modules
ziopio 2812ada
Move log loop in a dedicated gen_server
ziopio 87e8b81
Downgradde wait log to info to lower noise in serial output
ziopio 85c619a
Set logline as error and make it a structured log
ziopio b73b884
Fix typo in readme
ziopio 9437cf7
Handle unexpected send_logs messages and warn about them
ziopio a029a29
Add binlog test suite
ziopio b6372b5
Add comments to the supervisor code
ziopio 41556ea
Replace log longs with a warning reporting its size
ziopio 26a35ce
Fix binlog bug
ziopio 7c23335
Add argument to set maximum byte size of the log chunk
ziopio 57a0c35
Simplify supervisor explanation
ziopio 7edcbca
Add explanation and example config for swapping the default logger an…
ziopio 048d1d0
Correct wording in README
ziopio 4e9bb61
Adjust wording in README
maehjam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug could also affect DAB
It happens when the client does not send the whole log queue and later syncs the logs.
This can result in a repeated log sent to the server or, way worse, infinite loop.
I had an infinite loop in my case because now I am forcing the chunk to be under a fixed byte size. So I had a queue long 2 and always sending only one log. This was resulting in a failed sync because of this truncate function. And this would endup looping forever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For DAB this may cause a log line to be sent 2 times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this image as reference for the protocol algorithm https://github.com/stritzinger/dab/blob/master/docs/log_buffer.excalidraw.png