Automated logging towards GRiSP.io #18
Conversation
ziopio
force-pushed
the
ziopio/logger
branch
from
b60918e
to
142dcbe
Compare
ziopio
force-pushed
the
ziopio/logger
branch
4 times, most recently
from
4042d76
to
965c1fd
Compare
ziopio
changed the title
They are not so tied to the websocket
Maximum size is hardcoded to 30_000 to avoid rtems bug
Truncate function is not dropping the target index returned by the server
Maximum size is hardcoded to avoid rtems bug
| @@ -80,7 +80,7 @@ truncate(To, #binlog{seq = Seq} = L) when To >= Seq -> | |||
| clear(L); | |||
| truncate(To, #binlog{queue = Q0} = L) -> | |||
| case queue:out(Q0) of | |||
| {{value, {Seq, Bin}}, Q1} when Seq < To -> | |||
| {{value, {Seq, Bin}}, Q1} when Seq =< To -> | |||
There was a problem hiding this comment.
This bug could also affect DAB
It happens when the client does not send the whole log queue and later syncs the logs.
This can result in a repeated log sent to the server or, way worse, infinite loop.
I had an infinite loop in my case because now I am forcing the chunk to be under a fixed byte size. So I had a queue long 2 and always sending only one log. This was resulting in a failed sync because of this truncate function. And this would endup looping forever.
There was a problem hiding this comment.
For DAB this may cause a log line to be sent 2 times.
There was a problem hiding this comment.
I used this image as reference for the protocol algorithm https://github.com/stritzinger/dab/blob/master/docs/log_buffer.excalidraw.png
…d get all logs into GRiSP.io
README.md
Outdated
| Once this app is started, it forwards all logs to GRiSP.io without the need of setting up anything. The only logs that we do not catch are the ones generated before `grisp_io` boots. | ||
| If you want to see ALL logs, even from applications that boot before `grisp_io`, you need to disable the default logger and set our logger as the default one. This involves changing the `kernel` and `grisp_io` app configuration settings in your sys.config file. | ||
|
|
||
| You can copy paste these settings. Here we both swap the default logger with ours and also request our logger to print logs to stdout. |
There was a problem hiding this comment.
Wording is a bit strange. It's not our logger, but a handler for the OTP logger. I would rather talk about "the grisp_io logger handler" (or when we rename the repo "the grisp_connect logger handler"). Same for default logger, it's the default logger handler.
This logger is a copy from Adam's contribution in DAB.
The loop that gets the chunks and sends them via WS is handled with gen_statem timeouts in
grisp_io_client.If @bchassoul frontend changes https://github.com/stritzinger/grisp_manager/pull/41 are loaded into stage.grisp.io, it is possible to test this branch with the stage.
just set {domain, "stage.grisp.io"} in the grisp_io app config when deployng this app.
Your board needs to be linked to see its logs on the web page, but the logs will be sent anyway.