Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_2to3 and setuptools 58+ problem #712

Closed
Stikus opened this issue Sep 29, 2021 · 8 comments · Fixed by #717 or #955
Closed

use_2to3 and setuptools 58+ problem #712

Stikus opened this issue Sep 29, 2021 · 8 comments · Fixed by #717 or #955

Comments

@Stikus
Copy link

Stikus commented Sep 29, 2021

Hello.
use_2to3 support was removed in setuptools 58 changelog

pVACtools dependency PyVCF still have it (PR about removing).

We should:

  1. Choose another dependency (maybe https://github.com/brentp/cyvcf2)
  2. Choose patched version from PR or something similar
  3. Pin setuptools version, but this is MAJOR problem for all future releases.
@Stikus
Copy link
Author

Stikus commented Sep 29, 2021

Similar problem for pysam.

Maybe another packages - a lot of packages still have use_2to3.
Here are some interesting workarounds: pypa/setuptools#2788

@susannasiebert
Copy link
Contributor

I will look into switching to a different vcf parsing library. I've used VCFPy successfully in other projects so that's what I would start with.

For pysam, since we're not pinning a version, having the change you linked released should be sufficient. Some of our dependencies might pin pysam but that would be up to them to update to a newer version.

@Stikus
Copy link
Author

Stikus commented Sep 30, 2021

pysam just released fixed release: https://github.com/pysam-developers/pysam/releases/tag/v0.17.0 FYI

Will wait for PyVCF replacement. Should we use setuptools<58 before you implement it?

@susannasiebert
Copy link
Contributor

Yes, you will need to use an older setuptools version. Alternatively, you can use the existing docker container (griffithlab/pvactools) to get around any installation problems.

@susannasiebert
Copy link
Contributor

Unfortunately, switching pVACtools to vcfpy is not sufficient to fix this problem. pVACtools also depends on vaxrank, which depends on varcode, which also depends on pyvcf. I made openvax/varcode#247 in the hopes that the varcode developers will address this issue.

@biolxy
Copy link

biolxy commented Aug 4, 2022

pip install setuptools==57.5.0 

@Stikus
Copy link
Author

Stikus commented Apr 18, 2023

Looks like varcode moved to pyvcf3 and you can update setuptools finally?

@Stikus
Copy link
Author

Stikus commented Dec 13, 2023

Looks like issue should be closed, but something went wrong.

@Stikus Stikus closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants