Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a new EXISTS expert filter operator and PLANNED_ACTIVE_POWER_SET… #80

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Adds a new EXISTS expert filter operator and PLANNED_ACTIVE_POWER_SET… #80

merged 4 commits into from
Nov 28, 2023

Conversation

EstherDarkish
Copy link
Contributor

…_POINT new field for generators.

@antoinebhs
Copy link
Contributor

@EstherDarkish, I think we should add a test for the option PLANNED_ACTIVE_POWER_SET_POINT

BOUTIER Charly added 2 commits November 27, 2023 23:23
Exists operator in expert filter now correctly works if no value is s…
53cb337 
…ent by the frontend.

Signed-off-by: BOUTIER Charly <[email protected]>
Adds unit test for extension
c1b8fad 
Signed-off-by: BOUTIER Charly <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.3% 91.3% Coverage
0.0% 0.0% Duplication

thangqp
thangqp approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@thangqp thangqp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK
Code OK

'null' is still saved for EXISTE operator of the filter in the db but this will be corrected in the next PR: #78

antoinebhs
antoinebhs approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Tests OK

@EstherDarkish EstherDarkish merged commit 0cd539e into main Nov 28, 2023
4 checks passed
@EstherDarkish EstherDarkish deleted the expert_filter_exists branch November 28, 2023 17:10
@thangqp thangqp mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinebhs antoinebhs antoinebhs approved these changes

@thangqp thangqp thangqp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EstherDarkish @antoinebhs @thangqp