Dynamic Simulation - Curve Configuration - Add some expert filter's criteria for Load and Generator and new operators IN, NOT_IN #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riteria for Load and Generator
…ome_filter_expert_criteria
thangqp
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Comment on lines
+75
to
+77
| if (isMultipleCriteriaOperator(this.getOperator())) { // multiple values | ||
| return this.getValues().stream().map(String::valueOf).collect(Collectors.joining(",")); | ||
| } else { // single value or absence |
There was a problem hiding this comment.
Maybe return an empty string, null or String.valueOf(Collections.<String>emptySet()) if this.values is null ?
This is to prevent a NPE.
There was a problem hiding this comment.
Should manage at DTO level by a validator to do a cross validation between two fields. This will be corrected in another PR
Comment on lines
+45
to
+47
| if (isMultipleCriteriaOperator(this.getOperator())) { // multiple values | ||
| return String.join(",", this.getValues()); | ||
| } else { // single value or absence |
There was a problem hiding this comment.
Same here, throws a NPE if this.getValues() is null.
There was a problem hiding this comment.
Idem! Should manage at DTO level by a validator to do a cross validation between two fields. This will be corrected in another PR
Comment on lines
+67
to
+68
| case IN -> this.getValues().contains(identifiableValue); | ||
| case NOT_IN -> !this.getValues().contains(identifiableValue); |
There was a problem hiding this comment.
Idem! Should manage at DTO level by a validator to do a cross validation between two fields. This will be corrected in another PR
Comment on lines
+67
to
+68
| case IN -> this.getValues().contains(identifiableValue); | ||
| case NOT_IN -> !this.getValues().contains(identifiableValue); |
There was a problem hiding this comment.
Idem! Should manage at DTO level by a validator to do a cross validation between two fields. This will be corrected in another PR
EstherDarkish
approved these changes
Nov 29, 2023
jonenst
approved these changes
Nov 29, 2023
thangqp
deleted the
dynamic_simulation_curve_configuration_add_some_filter_expert_criteria
branch
This was referenced Nov 30, 2023
Dynamic Simulation - Rework on curve configuration to use expert filter
gridsuite/gridstudy-app#1658
Merged
thangqp
added a commit
to gridsuite/gridstudy-app
that referenced
this pull request
Jan 10, 2024
…er (#1658) This PR hasn't any functional evolution on curve configuration. The GUI is unchanged Related PRs: Back-end : gridsuite/study-server#476 gridsuite/network-map-server#147 gridsuite/filter-server#78
thangqp
added a commit
to gridsuite/study-server
that referenced
this pull request
Jan 10, 2024
…lter and to get all countries of network (#476) Related PRs: Front-end : gridsuite/gridstudy-app#1658 (with demo) Back-end : gridsuite/network-map-server#147 gridsuite/filter-server#78
thangqp
added a commit
to gridsuite/network-map-server
that referenced
this pull request
Jan 10, 2024
…ies of a network (#147) Related PRs: Front-end : gridsuite/gridstudy-app#1658 (with demo) Back-end : gridsuite/study-server#476 gridsuite/filter-server#78
lilian-houdelet
pushed a commit
to gridsuite/gridstudy-app
that referenced
this pull request
Jan 18, 2024
…er (#1658) This PR hasn't any functional evolution on curve configuration. The GUI is unchanged Related PRs: Back-end : gridsuite/study-server#476 gridsuite/network-map-server#147 gridsuite/filter-server#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Front-end :
gridsuite/gridstudy-app#1658 (with demo)
Back-end :
gridsuite/study-server#476
gridsuite/network-map-server#147