Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET-562] Persistent Keep Alive from node to host #2604

Merged
merged 25 commits into from
Oct 6, 2023
Merged

Conversation

gabrielseibel1
Copy link
Contributor

Describe your changes

Move PKA from node to host level

Provide testing steps

Described in ticket

@Aceix
Copy link
Contributor

Aceix commented Sep 26, 2023

Will definitely need a UI change as well

Copy link
Contributor

@mattkasun mattkasun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when a server is updated to this version; how are the host and node models updated. The new node model will just ignore the keepalive in the database, but how will the host.Keepalive value be set?

logic/hosts.go Outdated Show resolved Hide resolved
logic/wireguard.go Show resolved Hide resolved
logic/wireguard.go Outdated Show resolved Hide resolved
models/api_host.go Outdated Show resolved Hide resolved
@gabrielseibel1
Copy link
Contributor Author

when a server is updated to this version; how are the host and node models updated. The new node model will just ignore the keepalive in the database, but how will the host.Keepalive value be set?

@mattkasun I've implemented logic for that in f67bff1 (f67bff1#diff-24c3832e2410ce37a7dfb88d3b4bf45a0506ce708774402fecddb5e96f9ff8d8R169) and in 10c3416, is that sufficient for your concern?

@mattkasun
Copy link
Contributor

when a server is updated to this version; how are the host and node models updated. The new node model will just ignore the keepalive in the database, but how will the host.Keepalive value be set?

@mattkasun I've implemented logic for that in f67bff1 (f67bff1#diff-24c3832e2410ce37a7dfb88d3b4bf45a0506ce708774402fecddb5e96f9ff8d8R169) and in 10c3416, is that sufficient for your concern?

Migrate is only called on update from v0.17.1

swagger.yml Outdated Show resolved Hide resolved
controllers/enrollmentkeys.go Outdated Show resolved Hide resolved
logic/peers.go Show resolved Hide resolved
models/api_host.go Outdated Show resolved Hide resolved
@abhishek9686
Copy link
Member

@gabrielseibel1 resolve conflicts

models/api_host.go Outdated Show resolved Hide resolved
models/api_host.go Outdated Show resolved Hide resolved
@abhishek9686 abhishek9686 merged commit cb4b99f into develop Oct 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants