Remove refs to Node.PKA #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielseibel1
requested review from
mattkasun,
abhishek9686,
Aceix,
theguy951357,
pwilson77,
afeiszli and
uGiFarukh
and removed request for
mattkasun
abhishek9686
approved these changes
Oct 2, 2023
mattkasun
approved these changes
Oct 4, 2023
theguy951357
approved these changes
Oct 5, 2023
Aceix
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Remove references to Node.PersistentKeepalive, moved to host level.
https://github.com/gravitl/netclient/compare/net-562-adapt?expand=1#diff-e14bc0ffe852c3142c0d54fd6df7a61dc8c7b6da0c341a02b445a10ad856d536L36
https://github.com/gravitl/netclient/compare/net-562-adapt?expand=1#diff-70584e473f85ce4411dcfc16e85af66d4b0692f504a11c7e38e3e763c665f658L192
https://github.com/gravitl/netclient/compare/net-562-adapt?expand=1#diff-70584e473f85ce4411dcfc16e85af66d4b0692f504a11c7e38e3e763c665f658L147
Provide Issue ticket number if applicable/not in title
NET-562
Provide link to Netmaker PR if required
gravitl/netmaker#2604