-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Managed service accounts disclaimer and config option #1142
base: main
Are you sure you want to change the base?
Conversation
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
I'll GA the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two small comments, but feel free to merge as is :)
**Enabling the Feature:** | ||
|
||
- Grafana versions **below 11.3.0**: Enable the `externalServiceAccounts` feature toggle. | ||
- Grafana **11.3.0 and later**: Activate the `managed_service_accounts_enabled` configuration option in the [auth section](https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#auth-section) of your Grafana configuration file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think the word "activate" is slightly confusing.
- Grafana **11.3.0 and later**: Activate the `managed_service_accounts_enabled` configuration option in the [auth section](https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#auth-section) of your Grafana configuration file. | |
- Grafana **11.3.0 and later**: Set the `managed_service_accounts_enabled` configuration option to `true`. You can find this option in the [auth section](https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#auth-section) of your Grafana configuration file. |
What this PR does / why we need it:
This PR documents the
managed_service_accounts_enabled
configuration option that is used in place of the externalServiceAccounts feature toggle starting with 11.3.0 (grafana/grafana#93384)Following grafana/grafana#91844, I thought we could make it extra clear that we only support single organization setups.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Associated with: grafana/grafana#93883