Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Reflect managed service accounts feature GA #389

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Docs: Reflect managed service accounts feature GA #389

wants to merge 1 commit into from

Conversation

gamab
Copy link
Contributor

@gamab gamab commented Oct 4, 2024

This PR documents the managed_service_accounts_enabled configuration option that is used in place of the externalServiceAccounts feature toggle starting with 11.3.0

Follow up to:

@gamab gamab requested review from a team as code owners October 4, 2024 07:41
@gamab gamab requested review from Ukochka, wbrowne, marefr and andresmgot and removed request for a team October 4, 2024 07:41
@gamab gamab self-assigned this Oct 4, 2024
@gamab gamab mentioned this pull request Oct 4, 2024
Merged
IevaVasiljeva
IevaVasiljeva approved these changes Oct 4, 2024
View reviewed changes
Copy link

@IevaVasiljeva IevaVasiljeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback as for the other PR regarding "activate", but otherwise looks good.

andresmgot
andresmgot approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gamab gamab marked this pull request as draft October 4, 2024 15:31
@marefr marefr removed their request for review October 8, 2024 12:16
@Jguer Jguer unassigned gamab Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IevaVasiljeva IevaVasiljeva IevaVasiljeva approved these changes

@andresmgot andresmgot andresmgot approved these changes

@Ukochka Ukochka Awaiting requested review from Ukochka Ukochka is a code owner automatically assigned from grafana/plugins-platform-frontend

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees
No one assigned
Labels
None yet
Projects
Plugins Platform / Grafana Community
Status: 🔬 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gamab @andresmgot @IevaVasiljeva