Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Metrics dashboard for NGINX #1346

Merged
merged 9 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nginx-mixin/README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the readme below your already changed parts to include a bit of detail on the added dashboard?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added now

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Nginx Mixin

This mixin is a thin veneer over the dashboard designed and published by [Ward Bekker](https://grafana.com/orgs/wardbekker1) in the [Grafana dashboards library](https://grafana.com/grafana/dashboards/12559).
This mixin is a thin veneer over the dashboard designed and published by [Ward Bekker](https://grafana.com/orgs/wardbekker1) in the [Grafana dashboards library](https://grafana.com/grafana/dashboards/12559) and the metrics dashboard is collected from the [official NGINX exporter repository](https://github.com/nginxinc/nginx-prometheus-exporter/blob/main/grafana/dashboard.png).

Specifically this mixin adds a configurable `cluster` variable to the dashboard in order to support it's use in one or many kubernetes clusters.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2190,8 +2190,8 @@
]
},
"timezone": "",
"title": "Nginx access logs",
"title": "NGINX Logs",
"uid": "T512JVH7z",
"version": 4,
"weekStart": ""
}
}
Loading
Loading