Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Metrics dashboard for NGINX #1346

Merged
merged 9 commits into from
Oct 22, 2024
Merged

feat: Add Metrics dashboard for NGINX #1346

merged 9 commits into from
Oct 22, 2024

Conversation

ishanjainn
Copy link
Member

@ishanjainn ishanjainn commented Oct 15, 2024 •
edited
Loading

Currently the NGINX mixin only has the logs dashboard and this PR adds a metrics dashboard

Screenshot 2024-10-21 at 12 40 36 PM

@ishanjainn ishanjainn requested a review from a team as a code owner October 15, 2024 19:04
Dasomeone
Dasomeone reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just one comment outstanding

nginx-mixin/README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the readme below your already changed parts to include a bit of detail on the added dashboard?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added now

Dasomeone
Dasomeone requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry looks like I missed a couple important points in the last review, can you please have a look? Feel free to shoot me a message if you have any questions :D

nginx-mixin/dashboards/nginx-metrics.json Outdated
"id": "grafana",
"name": "Grafana",
"type": "grafana",
"version": "5.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait actually I just realised, this is a dashboard built on the much much older Grafana scheme, we'll need to upgrade this at the very least to Grafana 10/11 to remove any Angular based panels

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, dashboard should be updated now

nginx-mixin/dashboards/nginx-metrics.json Outdated Show resolved Hide resolved
nginx-mixin/dashboards/nginx-metrics.json Show resolved Hide resolved
Dasomeone
Dasomeone approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minuscule missing newlines, but otherwise LGTM. Approving now so you can make those changes and merge :)

nginx-mixin/.lint Outdated Show resolved Hide resolved
nginx-mixin/dashboards/nginx-metrics.json Outdated Show resolved Hide resolved
@Dasomeone Dasomeone merged commit ab03d60 into master Oct 22, 2024
3 checks passed
@Dasomeone Dasomeone deleted the nginx-mixin branch October 22, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dasomeone Dasomeone Dasomeone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishanjainn @Dasomeone