Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Github App credentials for issue commands workflow #280

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Use Github App credentials for issue commands workflow #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/issue_commands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,14 @@ jobs:
ref: main
- name: Install Actions
run: npm install --production --prefix ./actions
- name: "Generate token"
id: generate_token
uses: tibdex/github-app-token@b62528385c34dbc9f38e5f4225ac829252d1ea92
Copy link
Member

@sarahzinger sarahzinger Sep 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this? and why not something like tibdex/github-app-token@v2 is this a specific git commit that we need for some reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action turns the private key from the app into a token that's usable for running the issue_commands. But I actually don't know why the recommendation was to use that particular commit. This is a good callout! I will ask

with:
app_id: ${{ secrets.AWS_DS_TOKEN_CREATOR_ID }}
private_key: ${{ secrets.AWS_DS_TOKEN_CREATOR_PEM }}
- name: Run Commands
uses: ./actions/commands
with:
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ steps.generate_token.outputs.token }}
configPath: issue_commands