Use Github App credentials for issue commands workflow #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
reviewed
Sep 26, 2023
| @@ -17,8 +17,14 @@ jobs: | |||
| ref: main | |||
| - name: Install Actions | |||
| run: npm install --production --prefix ./actions | |||
| - name: "Generate token" | |||
| id: generate_token | |||
| uses: tibdex/github-app-token@b62528385c34dbc9f38e5f4225ac829252d1ea92 | |||
There was a problem hiding this comment.
what's this? and why not something like tibdex/github-app-token@v2 is this a specific git commit that we need for some reason?
There was a problem hiding this comment.
This action turns the private key from the app into a token that's usable for running the issue_commands. But I actually don't know why the recommendation was to use that particular commit. This is a good callout! I will ask
sarahzinger
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly fix workflow - same as grafana/grafana-iot-twinmaker-app#222