feat: provide more field support for rpms #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djgilcrease
force-pushed
the
feature/support-more-rpm-features
branch
from
293d575
to
e4b8762
Compare
Closed
|
LGTM so far :D |
added 2 commits
October 8, 2019 11:45
New RPM fields --- * Description * OS <= info.Platform * Licence * URL <= info.Homepage * Vendor * Packager <= info.Maintainer * Provides * Require <= info.Depends * Obsolete <= info.Replaces * Suggests * Conflicts Fixes --- * RPM Compression types are supported again * RPM Config files are supported again * `rpmpack` will support all the rpm file types, so we could extend this more latter
djgilcrease
force-pushed
the
feature/support-more-rpm-features
branch
from
e4b8762
to
4b772d8
Compare
…e decide to enable it
djgilcrease
changed the title
|
Should be all good now |
caarlos0
reviewed
Oct 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=========================================
Coverage ? 71.09%
=========================================
Files ? 5
Lines ? 467
Branches ? 0
=========================================
Hits ? 332
Misses ? 84
Partials ? 51
Continue to review full report at Codecov.
|
caarlos0
changed the title
|
awesome, thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New RPM fields
Fixes
rpmpacksupports all the rpm file types, so we could extend this more latterCloses: #71 #54