Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide files as tgz #43

Closed
tcurdt opened this issue Nov 28, 2018 · 12 comments
Closed

Provide files as tgz #43

tcurdt opened this issue Nov 28, 2018 · 12 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tcurdt
Copy link

tcurdt commented Nov 28, 2018

It seems like right now there is no way to specify a full tgz for the files that should go into the package. And there is no way to specify the ownership and permissions in detail (that I see).

Would be great if one could provide a complete tgz as the data section of package.

@tcurdt tcurdt changed the title provide files as tgz Provide files as tgz Nov 28, 2018
@caarlos0 caarlos0 added the enhancement New feature or request label Nov 28, 2018
@caarlos0
Copy link
Member

hmm, maybe...

@tcurdt
Copy link
Author

tcurdt commented Nov 28, 2018

That sounds very sceptical :) May I ask why?
How do you setup permissions of the files included in the package at the moment instead?

@caarlos0
Copy link
Member

sorry, didn't meant to sound very skeptical haha

right now, as far as I remember, it uses whatever permissions the files already have, although I agree that's not ideal.

I use it only on goreleaser itself, and for what goreleaser supports that was never a problem, but to support "power users" I agree there must be a better way...

@tcurdt
Copy link
Author

tcurdt commented Nov 28, 2018

If you have any thoughts on how you this could or should be added best I am all ears.
Maybe I can then work on a PR.

@jarondl
Copy link
Contributor

jarondl commented Oct 4, 2019

Now with #79 by @djgilcrease , nfpm can perhaps offer using rpmpack.FromTar as an additional input method.

@djgilcrease djgilcrease added the good first issue Good for newcomers label Oct 10, 2019
@mig4
Copy link

mig4 commented Oct 30, 2019

So is the idea here to have an optional property in the config file along the lines of files_from_tar which would cause the files from the specified tar archive be added to the package in addition to the ones specified in files property?

@tcurdt
Copy link
Author

tcurdt commented Oct 30, 2019

@mig4 the original idea was without the "in addition" part. Essentially all data files in the package in one tgz. Which means all permissions and ownerships are defined.

In addition would of course be an option, too.

@djgilcrease
Copy link
Contributor

djgilcrease commented Oct 30, 2019

I would say add a FilesTar string to Overridables make sure it is mutually exclusive with the Files []string then update deb/createDataTarGz to use the passed in FilesTar if set && update rpm/Package to use rpmpack/FromTar if FilesTar is set

@mig4
Copy link

mig4 commented Oct 31, 2019

Yeah, I just wanted to confirm the expectation was that this would be an additional option in the config file, instead of a CLI arg for example. As for in addition/instead, whatever makes most sense. I'll give it a spin and propose something and we can discuss the details there sure.

Many thanks for the pointers @djgilcrease 😁

@caarlos0
Copy link
Member

closing due to lack of interest from the community

@caarlos0 caarlos0 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2024
@tcurdt
Copy link
Author

tcurdt commented Mar 16, 2024

@caarlos0 is there any other way to specify ownership and permissions of files inside the package by now?

@caarlos0
Copy link
Member

yes, https://nfpm.goreleaser.com/configuration/?h=file_info#reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants