fix: fix typing issue with gRPC metadata when key ends in -bin #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
changed the title
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: xl
vchudnov-g
approved these changes
Nov 22, 2024
Comment on lines
462
to
463
| sent along with the request as metadata. If the metadata key has | ||
| suffix `-bin`, the value must be bytes.{% endmacro %} |
There was a problem hiding this comment.
Suggested change
| sent along with the request as metadata. If the metadata key has | |
| suffix `-bin`, the value must be bytes.{% endmacro %} | |
| Key/value pairs which should be sent along with the request as metadata. Normally, each value must be of type `string`, but for metadata keys ending with the | |
| suffix `-bin`, the corresponding values must be of type `bytes`.{% endmacro %} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #2253 which adds a macro for metadata
Fixes #2250 🦕