Skip to content

Commit

Permalink
fix: fix typing issue with gRPC metadata when key ends in
Browse files Browse the repository at this point in the history
  • Loading branch information
parthea committed Nov 16, 2024
1 parent e04cbb5 commit 7da6a2a
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions tests/system/test_request_metadata.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from google import showcase


def test_metadata_string(echo):
echo.echo(
showcase.EchoRequest(
content="The hail in Wales falls mainly on the snails.",
request_id="some_value",
other_request_id="",
),
metadata=[('some-key', 'some_value')]
)


def test_metadata_binary(echo):
# See https://github.com/googleapis/gapic-generator-python/issues/2250
# When the metadata key ends in `-bin`, the value should be of type
# `bytes`` rather than `str``.
echo.echo(
showcase.EchoRequest(
content="The hail in Wales falls mainly on the snails.",
request_id="some_value",
other_request_id="",
),
metadata=[('some-key-bin', b'some_value')]
)

0 comments on commit 7da6a2a

Please sign in to comment.