feat(AIP-203): require field_behavior #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding guidance from aip-dev/google.aip.dev#1100
shwoodard
reviewed
May 11, 2023
noahdietz
reviewed
May 23, 2023
- making it a method rule, checkin the request. - handling the nested message case.
removing optional_consistency, which is now redundant.
noahdietz
reviewed
May 24, 2023
There was a problem hiding this comment.
LGTM great job. I'll let @shwoodard approve as I think he's got an open question still
- adding immutable as one of the required behaviors.
|
Including |
shwoodard
reviewed
May 25, 2023
fix nits, lint problem pointer -> list
|
@shwoodard thanks! ready for another pass from you. Noah deferred to your approval since you had blocking comments before. |
shwoodard
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding guidance from aip-dev/google.aip.dev#1100