Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-203: require field_behavior #1102

Closed
toumorokoshi opened this issue Mar 1, 2023 · 6 comments
Closed

AIP-203: require field_behavior #1102

toumorokoshi opened this issue Mar 1, 2023 · 6 comments

Comments

@toumorokoshi
Copy link
Contributor

AIP-203 states:

APIs should use the google.api.field_behavior annotation to describe well-understood field behavior, such as a field's being required, immutable, or output only:

This is not verified by the api-linter today.

@toumorokoshi
Copy link
Contributor Author

likely we could force this by requiring that at least one of required, optional, output_only, or input_only is set.

@toumorokoshi
Copy link
Contributor Author

toumorokoshi commented Mar 1, 2023

side note for discussion: I'm not sure why optional and input_only is not a valid combination, but TBInvestigated.

@shwoodard
Copy link
Collaborator

Would this be ubiquitous or Cloud only?

@toumorokoshi
Copy link
Contributor Author

I'd say in general these should be ubiquitous unless there's a good reason to scope it.

@shwoodard
Copy link
Collaborator

Are there other values that might be reasonable for the set? iirc there was additional values that tf uses.

@toumorokoshi
Copy link
Contributor Author

fixed with #1149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants