Deprecate Sigma status CSV usage from code #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaegeral
added
Sigma
|
If the CSV file has been deprecated can you add a note in it that says so? Then we can mark it for deletion in a couple of months. |
jkppr
reviewed
Sep 29, 2023
jaegeral
changed the title
clarified in the PR description, the usage of the file has been deprecated, the content of the file itself might still be valuable for me / others, thus moving it to contrib outside of the data folder, as the file itself is no longer used in the code. |
jaegeral
changed the title
jkppr
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some left overs from the old File based Sigma usage.
As the sigma rule status csv is not maintained, it is removed
If there is a new need / desire to track status of upstream Sigma rules and which work in Timesketch / which not, a new way needs to be established, a CSV does not play nice with the community.