-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add yosys optimizer pass #191
Conversation
36ca7d2
to
e26b491
Compare
015cfe6
to
fba4802
Compare
4d0b6b3
to
e5a5383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review now!
I'm not 10000% sold on the env vars, only because it makes running as a bazel-bin binary one step harder, but that's not super high priority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I left a bunch of comments, but I think this PR is very straightforward and easy to understand. Very well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
7fd6185
to
99ccfd1
Compare
Signed-off-by: Asra Ali <[email protected]>
99ccfd1
to
f99242b
Compare
Hooray!! 🎉
…On Tue, Oct 31, 2023, 7:54 AM copybara-service[bot] < ***@***.***> wrote:
Merged #191 <#191> into main.
—
Reply to this email directly, view it on GitHub
<#191 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAS2PKRYQPBBRZ2RJO2D5WTYCEGLTAVCNFSM6AAAAAA5WHJLNCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHAZDEMBWGAYTSNQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I know! one step closer :P |
Part of #111
This adds a global yosys optimization on a program - it booleanizes the arithmetic circuit, and then converts it into LUTs from the comb dialect.