Adjust MarshalSubjectAltName to allow SANs to be critical #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonweeks
requested changes
Mar 26, 2024
liamjm
changed the title
|
Squashing done, and update from master branch. |
brandonweeks
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both AKs and EKs the Subject Alt Name extension may be critical, or non-critical, based on the presence of the subject field.
So we need to expose control over this criticality to the caller, as detailed more in #366 .
This PR adds a new method MarshalSubjectAltNameWithCriticality that accepts a bool to control the criticality. The existing method (MarshalSubjectAltName) that specifies the extension non-critical is left untouched to maintain compatibility.