Just add critical bool to MarshalSubjectAltName

google · Mar 26, 2024 · ee1735b · ee1735b
1 parent cb5af8b
commit ee1735b
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/x509/x509ext.go b/x509/x509ext.go
@@ -149,14 +149,9 @@ func forEachSAN(extension []byte, callback func(ext asn1.RawValue) error) error
 	return nil
 }
 
-// MarshalSubjectAltName converts a SubjectAltName struct into a pkix.Extension.
-func MarshalSubjectAltName(san *SubjectAltName) (pkix.Extension, error) {
-	return MarshalSubjectAltNameWithCriticality(san, false)
-}
-
-// MarshalSubjectAltNameWithCriticality converts a SubjectAltName struct into a pkix.Extension,
+// MarshalSubjectAltName converts a SubjectAltName struct into a pkix.Extension,
 // allowing callers to specify if the extension is critical.
-func MarshalSubjectAltNameWithCriticality(san *SubjectAltName, critical bool) (pkix.Extension, error) {
+func MarshalSubjectAltName(san *SubjectAltName, critical bool) (pkix.Extension, error) {
 	var generalNames []asn1.RawValue
 	for _, permID := range san.PermanentIdentifiers {
 		val, err := marshalOtherName(oidPermanentIdentifier, permID)