-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es: Spanish translation refresh #2232
Conversation
Hey @carreter, this looks nice from a format point of view. I used
to skim through the diff. I don't know Spanish, so I cannot help with the actual content. |
Since this looks fine from a structure point, I'm happy to merge this if you can resolve the conflicts. You might need to hand-merge the out-of-date |
We probably need to run dprint here |
Hi @carreter , were you able to run dprint fmt on the file? If you've done that, would you also convert this PR from draft to ready to review? |
5f3b8d0
to
d81fac7
Compare
@henrif75 Done. I'll mark it ready to review but note that many of the entries are still untranslated. |
I reviewed the Spanish text added on this PR and all seems correct to me. |
I'll open a stacked PR for further translation work. Still have ~200 entries to go! |
Yay, thanks for the amazing work! Note that we squash-merge all PRs here — this makes it easier for new contributors since they can just pile on commit after commit in their PR without having to consider how the resulting history looks like. So it's fine to open a new PR with this as a base. |
Actually, I didn't look carefully enough: could you revert the changes to the other translations from this PR? I guess there is a version mismatch somewhere between the |
Must be complaining because I left Google. I can only seem to get the CLA to be signed with my Gmail account, @mgeisler do you know if there's a way to use a non-gmail address? |
On it! |
This reverts commit c6a66da.
CLA is working now and I have reverted the non-Spanish translation changes. @mgeisler let me know if anything else is needed! |
Excellent, great that you got it working! I know from the past that people do need a Google/Gmail account, but it is possible to add non-Gmail addresses to the CLA bot. |
Fixes #2120.