Add FhirEngine interface method 'withTransaction' #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support performing FhirEngine actions as a single atomic transaction
aditya-07
reviewed
May 16, 2024
aditya-07
reviewed
May 16, 2024
LZRS
force-pushed
the
2531-fhirengine-interface
branch
from
13b83cb
to
bf90f8c
Compare
LZRS
force-pushed
the
2531-fhirengine-interface
branch
from
bf90f8c
to
72be126
Compare
MJ1998
reviewed
Jun 13, 2024
MJ1998
reviewed
Jun 14, 2024
engine/src/test/java/com/google/android/fhir/impl/FhirEngineImplTest.kt
Outdated
Show resolved
Hide resolved
to better reflect need for atomic transactions
LZRS
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 26, 2024
LZRS
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jul 2, 2024
8 tasks
|
Note: Sync APIs are deprecated now and once removed we probably dont need the CRUDEngine interface. |
|
happy to merge once jajoo's comment's resolved. discussed with @aditya-07 who's also ok with this. |
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Sep 10, 2024
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
PERF
- WUP google#2669
- WUP google#2565
- WUP google#2561
- WUP google#2535
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Oct 2, 2024
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
PERF
- WUP google#2669
- WUP google#2565
- WUP google#2561
- WUP google#2535
and removed the CRUDEngine interface
LZRS
force-pushed
the
2531-fhirengine-interface
branch
from
3af9d14
to
b520d30
Compare
jingtang10
approved these changes
Oct 8, 2024
engine/src/main/java/com/google/android/fhir/impl/FhirEngineImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/impl/FhirEngineImplTest.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/impl/FhirEngineImplTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Oct 15, 2024
engine/src/test/java/com/google/android/fhir/impl/FhirEngineImplTest.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/impl/FhirEngineImplTest.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/impl/FhirEngineImplTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2531
Description
Support performing FhirEngine actions as a single atomic transaction
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.