Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of HumanoidBench tasks #339

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MoritzMeser
Copy link

Hello.
This is a new pull request to integrate some of the tasks from HumanoidBench into MJPC.

As discussed in the previous pull request (#328, which is now closed) and by mail, I have solved the issues we discussed earlier.

I updated the git tag for Menagerie to a version that includes the Unitree G1 robot. Because of this, I also had to update the patch file for the quadruped robot, so it is still compatible. I just copied the patch file there, which is on the "deepmind" branch of this repository.

@thowell thowell self-assigned this Aug 13, 2024
@thowell
Copy link
Collaborator

thowell commented Aug 13, 2024

Great tasks!

It looks like the floor is visualized a bit higher than the contact plane, let's modify the floor so that contacts with it are properly visualized.

For the H1 push task, can we make the box goal position interactive? We can use the same logic as the quadruped flat task to enable the user to move the goal mocap body via click and drag.

For the G1 walking task, have you tried using the same PD actuator model as the H1? Additionally, we might want to remove the hand DOFs from the model since they aren't used for locomotion and the additional DOFs make simulation more expensive. We should be able to reduce the planning horizon for this task to 0.35-0.4 seconds. Another way to improve this task is to replace the mesh collision geometries with primitives (eg, spheres, capsules).

Thanks!

@MoritzMeser
Copy link
Author

Yes, sure. I'll work through the points and then get back to you.

@MoritzMeser
Copy link
Author

Hi

I solved the issue with the floor and made the box goal interactive.

Regarding the G1 robot, I have remove the DOFs in the hand, but MPC still does not manage to keep standing. So I removed the G1 completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants