Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UMI-Gripper #97

Open
omarrayyann opened this issue Sep 25, 2024 · 5 comments
Open

Adding UMI-Gripper #97

omarrayyann opened this issue Sep 25, 2024 · 5 comments
Labels
new-model New model request

Comments

@omarrayyann
Copy link

omarrayyann commented Sep 25, 2024

Hello, I want to add the UMI-Gripper (https://umi-gripper.github.io). I imported the URDF and got the joints working. I would like to ask if there is any way to add mirrors in MuJoCo? The other option would be to add cameras where the mirrors are (would be enough since the position of the UMI camera is fixed relative to the mirror) and overlay the camera outputs over the UMI view. Let me know if you have any other suggestions.

Screen.Recording.2024-09-25.at.10.56.47.PM.mov
Screenshot 2024-09-26 at 1 00 47 AM
@omarrayyann omarrayyann added the new-model New model request label Sep 25, 2024
@yuvaltassa
Copy link
Collaborator

  1. This is awesome!
  2. I don't understand the question about mirrors? You want a reflective surface? The answer is yes, you can have one such surface.

@omarrayyann
Copy link
Author

I came across this: "Only the first reflective geom in the model is rendered as such". Is there no other way to have 2?

The UMI gripper has a mirror on each of the sides (trick to increase what it sees and give a virtual depth) as show here:

Screenshot 2024-09-26 at 8 04 47 PM Screenshot 2024-09-26 at 8 07 46 PM

I got one to work but the other does not reflect (probably has to do with the thing i mentioned up).

Screenshot 2024-09-26 at 7 53 38 PM Screenshot 2024-09-26 at 7 53 45 PM

Also, It might be a minor detail to add the mirrors anyways.

@yuvaltassa
Copy link
Collaborator

As I said, and as the docs say, you can have one such surface. I could try and increase it to two, not sure if anything would break.

In the meantime, place cameras in the correct locations such that the reflected image is the thing rendered by the camera and see that you get the correct match (use the one reflection you have now to debug this)

@kevinzakka
Copy link
Collaborator

Nice job @omarrayyann !

@omarrayyann
Copy link
Author

Opened a PR for this here: #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-model New model request
Projects
None yet
Development

No branches or pull requests

3 participants