Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent module creation pyright type errors #702

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Prevent module creation pyright type errors #702

merged 1 commit into from
Aug 2, 2023

Commits on Aug 1, 2023

  1. Prevent module creation pyright type errors 

    Creating any Haiku module gives type errors on the latest Pyright due to
the module metaclass specification
(microsoft/pyright#5561).  The issue is
that the ideal type annotation is an intersection of `type[T]` and
`ModuleMetaclass` where `T` is the return type, but Python doesn't have
type intersections yet.  The authors of the code chose `type[T]`, but
Pyright requires `ModuleMetaclass`.
    @NeilGirdhar
    NeilGirdhar committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    0a36df9 View commit details
    Browse the repository at this point in the history