Prevent module creation pyright type errors #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incidentally, I think most if not all of what is done in the metaclass should be moved into |
NeilGirdhar
force-pushed
the
fix_pyright
branch
3 times, most recently
from
32928f7
to
f0b8ec2
Compare
tomhennigan
approved these changes
Jul 29, 2023
|
Thanks, Neil! |
superbobry
reviewed
Jul 30, 2023
Creating any Haiku module gives type errors on the latest Pyright due to the module metaclass specification (microsoft/pyright#5561). The issue is that the ideal type annotation is an intersection of `type[T]` and `ModuleMetaclass` where `T` is the return type, but Python doesn't have type intersections yet. The authors of the code chose `type[T]`, but Pyright requires `ModuleMetaclass`.
NeilGirdhar
force-pushed
the
fix_pyright
branch
from
f0b8ec2
to
0a36df9
Compare
superbobry
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating any Haiku module gives type errors on the latest Pyright due to the module metaclass specification (microsoft/pyright#5561). The issue is that the ideal type annotation is an intersection of
type[T]andModuleMetaclasswhereTis the return type, but Python doesn't have type intersections yet. The authors of the code chosetype[T], but Pyright requiresModuleMetaclass.