feat: add ReportDialog #1453
Open
feat: add ReportDialog #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteranny
reviewed
Nov 18, 2024
| @@ -110,3 +110,7 @@ export const formatWage = wage => { | |||
|
|
|||
| export const formatDate = ({ year, month }) => | |||
| `${year}.${month >= 10 ? '' : 0}${month}`; | |||
|
|
|||
| export const getReportCount = (salaryWorkTimeReports = 0) => { | |||
There was a problem hiding this comment.
從 callsite 來看 input 應該是 Array？
Suggested change
| export const getReportCount = (salaryWorkTimeReports = 0) => { | |
| export const getReportCount = (salaryWorkTimeReports = []) => { |
| @@ -70,6 +73,13 @@ const ReactionZone = ({ experienceId, onClickMsgButton }) => { | |||
| > | |||
| 留言 | |||
| </ReactionButton> | |||
| <ReactionButton className={styles.report} Icon={() => null}> | |||
There was a problem hiding this comment.
建議直接修改 ReactionButton 讓 Icon 為 optional
Suggested change
| <ReactionButton className={styles.report} Icon={() => null}> | |
| <ReactionButton className={styles.report}> |
| const expInYearText = formatExperienceInYear(experience.experience_in_year); | ||
| return ( | ||
| <Fragment> | ||
| <div className={styles.reportDialogContainer}> | ||
| <ReportDialog reportCount={reportCount} /> | ||
| {Boolean(reportCount) && ( |
There was a problem hiding this comment.
Nit: 跟這個應該是一樣的意思
Suggested change
| {Boolean(reportCount) && ( | |
| {reportCount && ( |
|
Hi @YongChenSu please help take a look at @peteranny 's comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這個 PR 是？
Screenshots
我應該從何看起？
先給出 UI，功能實作中，回報數量先給預設常數。
Questions:
串 API 中
已驗證，
createSalaryWorkTimeReport、createExperienceReport、query experience功能正常。但無法
query salaryWorkTime，有可能是 query 下錯，詢問中，討論串連結我應該如何手動測試？
起 local