Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shorten the upper and lower spacing between the title and thumbs… #1437

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

YongChenSu
Copy link
Collaborator

Close #1432

這個 PR 是?

Shorten the upper and lower spacing between the title and thumbs on mobile screen width

Screenshots

修正後:
image

我應該如何手動測試?

檢查小螢幕寬度時,標題與讚的上下間距不會過高。

@YongChenSu YongChenSu self-assigned this Sep 5, 2024
@YongChenSu
Copy link
Collaborator Author

@barry800414 想稍微確認一下好了,我看 issue 的截圖是小尺寸螢幕時,上下間距過大。非小尺寸螢幕時,上下間距應該沒有要調整吧?目前如下:
image

@barry800414
Copy link
Contributor

@barry800414 想稍微確認一下好了,我看 issue 的截圖是小尺寸螢幕時,上下間距過大。非小尺寸螢幕時,上下間距應該沒有要調整吧?目前如下:

對的,不用調整,我 approved 了,感謝

@mark86092 mark86092 merged commit d3990ac into master Sep 18, 2024
8 checks passed
@mark86092 mark86092 deleted the feat/space-between-top-bottom branch September 18, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[前端][M1] 評價單篇的讚與面向間距過大
3 participants