[公司職稱頁面] Onblur搜尋 #1435
Merged
[公司職稱頁面] Onblur搜尋 #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
看起來可以進 stage 在手機測試測試？ |
mark86092
approved these changes
Sep 5, 2024
|
電腦版我有測試 |
|
我覺得只在 onblur 時觸發確實比較好 不過，想問薪資列表這點，有可能上方的加班情況區塊，不要 re render 嗎？ 畫面會跳來跳去的感覺 工作心得跟面試的列表因為上方沒東西，不會特別感受到畫面跳動 RPReplay_Final1725629614.mp4 |
barry800414
approved these changes
Sep 6, 2024
我同意，我另外發一個做做看 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這個 PR 是？
原本用 debounce 秒數搜尋
由於現在改用 API 搜尋，搜尋成本變高，切換頁面也影響使用者體驗
於是改用 onBlur 這類更明確的使用者 intention 來觸發搜尋
Screenshots
Untitled.mov
我應該如何手動測試？