refactor: login with google now use new SDK and flow #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wutingy this may need your help |
|
好我看一下 |
peteranny
reviewed
Jun 25, 2023
| > | ||
| <pre>Google 登入</pre> | ||
| <GoogleLoginButton onSuccess={() => {}} /> |
There was a problem hiding this comment.
可以讓 onSuccess optional 或是 default to () => {}，這樣這裡就不需要傳空的進去了
| gapi.auth2.init({ client_id: GOOGLE_APP_ID }); | ||
| const googleAuth = gapi.auth2.getAuthInstance(); | ||
| setGoogleAuth(googleAuth); | ||
| window.onload = function() { |
There was a problem hiding this comment.
需要...我想想怎麼改，或有建議怎麼做嗎？
There was a problem hiding this comment.
初步直覺想是這樣
let prevOnload = window.onload;
window.onload = function() {
if (prevOnload) prevOnload();
// ...
};There was a problem hiding this comment.
有 addEventListener 可以用，這樣就不用猜 on 的意思了
| }) | ||
| .then(() => authStatus.CONNECTED); | ||
| }) | ||
| .catch(err => authStatus.NOT_AUTHORIZED); |
There was a problem hiding this comment.
需要處理，列為之後 TODO 來解
|
|
mark86092
commented
Sep 12, 2023
| }} | ||
| > | ||
| Google 登入 | ||
| </button> |
mark86092
commented
Sep 12, 2023
| setLoginModalDisplayed, | ||
| }), | ||
| [isLoginModalDisplayed], | ||
| ); |
There was a problem hiding this comment.
React 推薦寫法，contextValue 改動，當且僅當 isLoginModalDisplayed 改動
|
@barry800414 @peteranny 改完了，再幫忙測試看看幾個登入點有沒有正常運作 |
peteranny
approved these changes
Sep 13, 2023
mark86092
changed the title
mark86092
added a commit
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #
這個 PR 是？
怎麼看 code
目前最新的 google login flow 禁止客製化登入按鈕(see ref link)，而是必須在畫面上 render "Sign in with Google" 按鈕
因為這件事，我做了幾個改變：
src/components/common/GoogleContextProvider/index.jsinit SDK 的時候，要提供 callback (L17~L19)這個 callback 當 User 按下 "Sign in with Google" 按鈕，完成 Google 登入後，會觸發的
我們會在這裡觸跟後端換發 token 機制
src/components/common/Auth/GoogleLoginButton.js由於沒辦法客製化登入按鈕，所以需要透過 google 幫我們 render "Sign in with Google" 按鈕未來 TODO & 需要幫忙的地方
GoogleLoginButton就可以解決了Ref
https://developers.google.com/identity/gsi/web/guides/integrate#button_customization