Enable tests for payments-dev branch #2724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new payment driver: update deps & remove zksync * new payment driver: initial integration * temporary fix of payment example -- will not work with new driver. TODO: make the new driver work in the example. * cleanup transfer, remove _transfer, remove gasless. * general way to compute chain_id based on config-payments.toml. * remove lots of code made obsolete by the new driver. * introduce signer for signing transactions for erc20_payment_lib * temporarily disable payment fund. --------- Co-authored-by: scx1332 <[email protected]>
kamirr
force-pushed
the
kek/enable-tests
branch
from
9294768
to
bc2d4fe
Compare
kamirr
force-pushed
the
kek/enable-tests
branch
from
198c627
to
30ecbcb
Compare
kamirr
force-pushed
the
kek/enable-tests
branch
from
451909e
to
df25e47
Compare
This test used a serde_json::Value -> flexbuffers -> Rust struct serde trip which is not guaranteed to work and should not be relied upon. The proper route is Value -> flexbuffers -> Value -> Rust. This only broke recently because without the arbitrary_precision feature of serde_json the shorter path works. The feature has been enabled due to the addition of erc20_payment_lib to the dependency graph, which transitively depends on serde_json with arbitrary prec. Note that cargo unifies duplicate dependencies under the assumption that features are purely additive, hence the spooky action at a distance.
This was
unlinked from
issues
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.