Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move payment driver config & database to yagna data directory #2714

Closed
kamirr opened this issue Aug 28, 2023 · 1 comment · Fixed by golemfactory/erc20_payment_lib#48 or #2736
Closed
Assignees

Comments

@kamirr
Copy link
Contributor

kamirr commented Aug 28, 2023

Acceptance critera:

  • Put erc20_payment_lib database in yagna data dir
  • Have the default config compiled into the source code & allow overriding the individual settings via ENV variables for each chain. Only expose:
    • rpc-endpoints
    • priority-fee
    • max-fee-per-gas
    • token.address (required by goth)
@kamirr
Copy link
Contributor Author

kamirr commented Sep 4, 2023

The change in yagna is a part of the PR that enables testing because it already has to deal with ENV variables set by goth, so splitting that into separate PRs would add more pointless work.

@kamirr kamirr reopened this Sep 7, 2023
@kamirr kamirr removed a link to a pull request Sep 7, 2023
@kamirr kamirr linked a pull request Sep 7, 2023 that will close this issue
@kamirr kamirr closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant