Refactor ColorPicker shapes #99515
Draft
Refactor ColorPicker shapes #99515
+692
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Nov 21, 2024
|
|
||
| ColorPickerShapeRectangle::ColorPickerShapeRectangle(ColorPicker *p_color_picker) : | ||
| ColorPickerShape(p_color_picker) { | ||
| int64_t self = reinterpret_cast<int64_t>(this); // Hack to allow connecting non-Object methods. |
There was a problem hiding this comment.
I don't like this hack, but I didn't have better idea. Alternative is making the shapes Object/RefCounted, but that would make them heavier than necessary (and each ColorPicker has a copy). It would make the code cleaner though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#4353
Basically #62075, but for picker shapes.
Adds a new class ColorPickerShape, which is an abstraction of picker shapes (similar to ColorMode). This allows to split some behemoth methods into a more manageable pieces. For now I removed the huge
_hsv_draw()method, which had entangled code for drawing every piece of ColorPicker. Now each part has its own method. The shapes should appear as before.TODO: