Implement DisplayServer.beep.
#99371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Nov 17, 2024
Comment on lines
+16
to
+17
| Plays the system beep sound, if possible. | ||
| [b]Note:[/b] This method is implemented on macOS, Linux (X11/Wayland) and Windows. |
There was a problem hiding this comment.
Suggested change
| Plays the system beep sound, if possible. | |
| [b]Note:[/b] This method is implemented on macOS, Linux (X11/Wayland) and Windows. | |
| Plays the system beep sound, if possible. This can be used to get the user's attention, e.g. if an error occurs in the application. | |
| The system beep sound depends on the operating system, but it can be changed or disabled at an OS level by the user. Unlike application-level audio playback, the system beep sound will be audible even if the application is muted in the engine's Master bus or in the system audio mixer. See also [method Window.request_attention]. | |
| [b]Note:[/b] This method is implemented on macOS, Linux (X11/Wayland) and Windows. |
There was a problem hiding this comment.
I don't think there's much need to be overly specific but this extra addendum is good.
Suggested change
| Plays the system beep sound, if possible. | |
| [b]Note:[/b] This method is implemented on macOS, Linux (X11/Wayland) and Windows. | |
| Plays the beep sound from the operative system, if possible. Because it comes from the OS, the beep sound will be audible even if the application is muted. It may also be disabled for the entire OS by the user. | |
| [b]Note:[/b] This method is implemented on macOS, Linux (X11/Wayland), and Windows. |
Or similar.
Riteo
approved these changes
Nov 17, 2024
Calinou
approved these changes
Nov 18, 2024
|
Why |
It depends on X11 and Wayland to work. |
mhilbrunner
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
DisplayServer.beepmethod to make annoying sounds.Implements godotengine/godot-proposals#11179