[Android] Update native dialog theme #98890
Open
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
m4gr3d
reviewed
Nov 6, 2024
There was a problem hiding this comment.
@syntaxerror247 Is it possible to set it through the theme instead, so that it's automatic for any UI element we create?
@m4gr3d Yes, I was trying to do that as well but encountered an issue with the navigation bar displaying a white color in light mode.
Edit: I just realised, I can manually set the system bar color to black in themes.xml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the theme for Android native dialogs to
Theme_DeviceDefault_Dialog_Alert(on API 22+) to better match the device’s default style. This makes the dialogs feel more consistent with the system theme, creating a smoother and more familiar experience for users.Size comparission of old and new apk
Before and After images of native dialogs
Before this PR
After this PR, tested on a Xiaomi device
After this PR, tested on a Motorola device