Fix Input::remove_joy_mapping
#98792
Open
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJacred
changed the title
MJacred
force-pushed
the
fix_remove_joy_mapping
branch
from
0c33bde to
42f5514
Compare
MJacred
changed the title
Input::remove_joy_mapping
MJacred
force-pushed
the
fix_remove_joy_mapping
branch
from
42f5514 to
fd8aa95
Compare
AThousandShips
added
bug
topic:input
crash
cherrypick:4.2
MJacred
force-pushed
the
fix_remove_joy_mapping
branch
from
fd8aa95 to
ce6fae4
Compare
MJacred
force-pushed
the
fix_remove_joy_mapping
branch
from
ce6fae4 to
556f90b
Compare
Mickeon
reviewed
Dec 15, 2024
MJacred
force-pushed
the
fix_remove_joy_mapping
branch
from
8a92f94 to
18bce29
Compare
Erasing a joypad mapping can invalidate other attached joypads and the fallback mapping guid
MJacred
force-pushed
the
fix_remove_joy_mapping
branch
from
18bce29 to
4083238
Compare
|
status update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erasing a joypad mapping can invalidate other attached joypads and the fallback mapping guid
Fixes #91257 (cannot confirm crash on Linux. Untested on Windows where it was observed)
If this PR is merged, it needs to be cherry-picked/backported to all supported Godot versions, afaik.
NOTE
I'm not sure if I handledfallback_mappingcorrectly, because according toInput::is_joy_knownthe fallback does not count as a known device… Therefore, feedback on this would be niceIf it's only meant as an internal fallback, a more minimal change of this PR to the fallback logic would be to deny removing the mapping for that one. Then I could remove the setter and getter for the fallback.-> Removed bindingsI renamed some members in windows joypad file to differentiate between direct INPUT and direct X. I found-> Renaming is done in another PRd_joypads, and it feels like thed_prefix was meant as a direct input abbreviation. So I used that. I'm open to alternative naming convention, though. Some renaming should happen to untangle INPUT and X.