CI: Install Android NDK r23c explicitly, with caching #85156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
topic:buildsystem
cherrypick:3.x
akien-mga
force-pushed
the
ci-android-enable-gradle-caching
branch
from
5385707
to
53279bf
Compare
akien-mga
changed the title
akien-mga
force-pushed
the
ci-android-enable-gradle-caching
branch
2 times, most recently
from
7b7e194
to
7f236de
Compare
akien-mga
changed the title
akien-mga
force-pushed
the
ci-android-enable-gradle-caching
branch
3 times, most recently
from
1be68c5
to
1b9ba42
Compare
akien-mga
changed the title
akien-mga
force-pushed
the
ci-android-enable-gradle-caching
branch
from
1b9ba42
to
0923a71
Compare
akien-mga
force-pushed
the
ci-android-enable-gradle-caching
branch
from
6bd9ecb
to
a42b054
Compare
YuriSizov
removed
the
cherrypick:4.1
The maintainer on setup-ndk seems busy and I don't want to add undue pressure. There aren't too much benefits from this PR as is so shelving it for now. |
akien-mga
added
archived
and removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to godotengine/godot-cpp#1314, where we don't rely on scons to download the NDK.
I wanted to enable the caching feature from https://github.com/nttld/setup-ndk, but it doesn't seem to work together with
link-sdk. So the gain from this change is just some clarity, it may not speed things up.Edit: Keeping as draft for now, blocked by nttld/setup-ndk#518. If we can get the cache to work, then this becomes useful.