-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] [tvOS] tvOS Support #58976
base: 3.x
Are you sure you want to change the base?
[3.x] [tvOS] tvOS Support #58976
Conversation
@@ -260,7 +260,7 @@ class PortalOcclusionCuller { | |||
|
|||
Occlusion::PolyPlane poly; | |||
uint32_t flags; | |||
#ifdef TOOLS_ENABLED | |||
#if defined(DEV_ENABLED) || defined(TOOLS_ENABLED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this change it's not possible to build debug
binaries for iOS
and tvOS
platforms.
d06d02c
to
ba49259
Compare
Great to see |
Could we not share the existing xcode |
I don't see a benefit in sharing single project with multiple targets for completely different export profiles that have completely different setting for each platform, plugins system and other stuff. |
Fair enough, we just had quite a few frameworks that are universal and our own workflow is usually out of a single .xcodeproj with multiple build targets instead of multiple .xcodeproj for each platform (iOS, MacOS, tvOS). Seemed like maintaining a single .xcodeproj with multiple build targets might have been easier than 3 separate, (Storyboard, launchscreen, could be shared, or whatever other universal resource or framework). I think the benefit may come from more in the maintenance of the .xcodeproj template in the godot repo itself (upgrade formats with new xcode versions, etc), not necessarily from sharing bundle ids, team ids, etc from a user's perspective. For specific configuration changes to a platform build target, we've always managed to achieve that pretty simple per target. But all-in-all, minor suggestion. |
@akien-mga is this PR supposed to be added to 4.0 milestone? #58977 is the [4.0] PR. |
@jordo @naithar Is the minor suggestion of keeping only one Would love to be able to support Apple Arcade demands of tvOS as well, when developing for their services. |
Rework of #45829 and #45830 PRs.
Implements proposal: godotengine/godot-proposals#224
tvOS
andiOS
platform uses newUIKit
platform to share functionality and code.UIKIT_ENABLED
flag is used instead ofIPHONE_ENABLED
.Export code is from previous PRs:
Mono haven't been ported.
GDNative uses same configuration as iOS platform.
Support plugins that works the same way as iOS, but configuration is using
.gdatvp
Related PRs: godotengine/build-containers#71, godotengine/godot-build-scripts#21 will be reworked for tvOS in future.