Google Play Billing Library v5 #36

timoschwarzer · 2022-09-01T20:09:15Z

This PR contains breaking changes

timoschwarzer · 2022-09-01T20:15:02Z

Disclaimer: I'm not able to test this. I created a prerelease on GitHub (https://github.com/godotengine/godot-google-play-billing/releases/tag/2.0.0-rc.1) which you can download and use as usual. The API is a bit different compared to v1 of the plugin. If you use it, please report back if everything works or you find issues. 🙌

bouncymarble · 2022-09-03T22:20:55Z

Hi, I'm trying to adapt the old plugin code with the new logic. First I had an error when connecting the signals:

payment.connect("sku_details_query_completed", self, "_on_sku_details_query_completed")
payment.connect("sku_details_query_error", self, "_on_sku_details_query_error")

But it was fixed by replacing the names:

payment.connect("product_details_query_completed", self, "_on_sku_details_query_completed")
payment.connect("product_details_query_error", self, "_on_sku_details_query_error")

Now I have this error: Invalid get index 'status' (on base: 'Nil')., when checking query status:

var query = payment.queryPurchases("inapp")
if query.status == OK:

query is also null with "subs", am I doing something wrong or is it an issue with this release?

I'd appreciate if anyone else testing the new plugin let me know how to make it work, as there's no currently updated docs to follow. According to google we have until november to migrate to billing library v4 or newer, but they seem to be delaying an update of mine, not sure if it's because I'm still using v3.

NianoTT · 2022-09-04T21:33:55Z

@bouncymarble

queryPurchases is async now, you need to do connect "query_purchases_response" and then call it like that:
payment.queryPurchases("inapp")

the function you connected to query_purchases_response will be emitted when it's done.

I got the plugin working for in app purchases, now need to test everything thouroghly, will report later.

bouncymarble · 2022-09-05T18:46:09Z

@NanitesNanites Thanks for your help, after some refactoring I managed to query product details and make purchases (consumables and non consumables). So I connected query_purchases_response as you said and I'm handling the purchase states in the function _on_query_purchases_response, although not sure if I'm checking the correct state, since the purchases dictionary returns purchase_state, but it also returns a dictionary called original_json which contains purchaseState. Anyways, I'm using the first one as it seems to match the states in this docs: https://developer.android.com/reference/com/android/billingclient/api/Purchase.PurchaseState#constants_1

The purchases dictionary also returns products, which seems to contain the product id, but I'm using productId from original_json which I think makes more sense:

product_id = parse_json(purchase.original_json).productId

Btw, I noticed that the plugin often disconnects for some reason, after starting the purchase of any product, I think it's when the signal purchases_updated is emitted, but then the purchase continues after the plugin tries to reconnect. Is that normal? can you check if the same happens to you?

Anyways, consumePurchase and acknowledgePurchase work as expected. I also did several tests with all the test cards, and everything is working :)

NianoTT · 2022-09-05T22:08:08Z

@bouncymarble

original_json is just the actual return from Google while the rest of the dictionary is constructed from it by the Billing Plugin, at least thats how I understand it from looking at the code. Don't think it matters which one to use?

I never could observe any disconnects.

@timoschwarzer I did test startConnection(), isReady(), querySkuDetails(), acknowledgePurchase(), purchase() for In App Purchases (non consumables only, also no Substriptions as I don't have any of that).

I did not run into any issues, after changing the signal names, making queryPurchases async and adjusting to the new dictionaries everything worked as before.

I hope others can check the things bouncymarble and me did not try like Subscriptions, and thank you for quickly making the upgrade to v5! Greatly appreciated :)

KoBeWi · 2023-01-15T19:06:59Z

...c/main/java/org/godotengine/godot/plugin/googleplaybilling/utils/GooglePlayBillingUtils.java

+			for (ProductDetails.SubscriptionOfferDetails subscriptionOfferDetails : subscriptionOfferDetailsList) {
+				Dictionary subscriptionOfferDetailsDictionary = new Dictionary();
+				subscriptionOfferDetailsDictionary.put("offer_token", subscriptionOfferDetails.getOfferToken());
+				subscriptionOfferDetailsDictionary.put("offer_tags", subscriptionOfferDetails.getOfferTags());


Suggested change

subscriptionOfferDetailsDictionary.put("offer_tags", subscriptionOfferDetails.getOfferTags());

Object[] array = subscriptionOfferDetails.getOfferTags().toArray();

subscriptionOfferDetailsDictionary.put("offer_tags", array);

ArrayList won't work in a Dictionary (it will come to Godot as null). It needs to be converted to array.

KoBeWi · 2023-01-15T19:07:18Z

...c/main/java/org/godotengine/godot/plugin/googleplaybilling/utils/GooglePlayBillingUtils.java

+					pricingPhasesDictionaryList.add(pricingPhasesDictionary);
+				}
+
+				subscriptionOfferDetailsDictionary.put("pricing_phases", pricingPhasesDictionaryList);


Suggested change

subscriptionOfferDetailsDictionary.put("pricing_phases", pricingPhasesDictionaryList);

array = pricingPhasesDictionaryList.toArray();

subscriptionOfferDetailsDictionary.put("pricing_phases", array);

Same.

KoBeWi · 2023-01-15T19:07:36Z

...c/main/java/org/godotengine/godot/plugin/googleplaybilling/utils/GooglePlayBillingUtils.java

+				subscriptionOfferDetailsDictionaryList.add(subscriptionOfferDetailsDictionary);
+			}
+
+			dictionary.put("subscription_offer_details", subscriptionOfferDetailsDictionaryList);


Suggested change

dictionary.put("subscription_offer_details", subscriptionOfferDetailsDictionaryList);

Object[] array = subscriptionOfferDetailsDictionaryList.toArray();

dictionary.put("subscription_offer_details", array);

Same™

KoBeWi · 2023-01-15T19:09:10Z

There is a bug in current 2.0.0rc1 where the returned offer details are null. I fixed it on my side, but I didn't technically clone the repo, so I couldn't figure out how to make a proper patch. You can use my review suggestions.

novalis · 2023-02-13T21:02:06Z

...ing/src/main/java/org/godotengine/godot/plugin/googleplaybilling/GodotGooglePlayBilling.java

-		signals.add(new SignalInfo("sku_details_query_completed", Object[].class));
-		signals.add(new SignalInfo("sku_details_query_error", Integer.class, String.class, String[].class));
+		signals.add(new SignalInfo("product_details_query_completed", Object[].class));
+		signals.add(new SignalInfo("product_details_query_error", Integer.class, String.class, String[].class));


The last argument here is String[], but below, it's called with List<ProductDetails>.

novalis · 2023-02-13T21:04:35Z

...ing/src/main/java/org/godotengine/godot/plugin/googleplaybilling/GodotGooglePlayBilling.java

 					}
-					emitSignal("sku_details_query_completed", (Object)GooglePlayBillingUtils.convertSkuDetailsListToDictionaryObjectArray(skuDetailsList));
+					emitSignal("product_details_query_completed", (Object)GooglePlayBillingUtils.convertProductDetailsListToDictionaryObjectArray(list));


I don't understand why this is being cast to Object -- isn't it already an Object? (It's actually Object[], but that is, itself, an object).

finepointcgi · 2023-05-19T21:58:05Z

I have tested the code with 6.0 and removed the legacy onPriceChangeConfirmationResult code. Do we want to merge this and do a pr for 6.0 or how do we want to work on this?
Edit: I have also tested both purchase and subscription and it does work.

LettucePie · 2023-05-25T16:10:32Z

Hello. New to this whole open contribution space. I have the plugin running off this branch, with changes by KoBeWi and novalis implemented.

I have most functions working so far that I have tested...

Sku Query (Request and Signals)
Purchases/Receipts (Request and Signals)
Purchase Requests (Request and Signals)
Purchase Acknowledgements (Request and Signals)
Start Connection (Request and Signals)
End Connection (Request)

I have only encountered one major issue so far and it was with the endConnection request and disconnected signal. I suddenly received a rogue disconnect signal after switching the accounts on my test device and re-exporting. It processed the connection, query, and receipts as expected, then after a short while it just disconnected itself.

Now after adding connection checks with reconnect logics to my buttons, I added a testing button to call endConnection. It calls it and internally disconnects, but fails to call the disconnect signal. For now I'm just calling my disconnect receiver function after calling out the endConnection as a temporary solution.

Maybe a faulty configuration on my end? Either way thought I should share.

Thank all of you either way for your work and contributions.

timoschwarzer mentioned this pull request Sep 1, 2022

Google Play Billing 4 will be required by Play Store from August 2, 2022 (new) / 1 November, 2022 (updates) #35

Open

Upgrade Gradle plugins, SDK version and Google Play Billing Library

265e78c

timoschwarzer force-pushed the billing-v5 branch from eeaf309 to 265e78c Compare September 1, 2022 21:04

NianoTT mentioned this pull request Jan 8, 2023

querySkuDetails with product type inapp return no data (null) #42

Closed

KoBeWi reviewed Jan 15, 2023

View reviewed changes

novalis reviewed Feb 13, 2023

View reviewed changes

finepointcgi mentioned this pull request May 19, 2023

Updated to 5.2 #45

Merged

NianoTT mentioned this pull request May 23, 2023

Signals not firing properly #47

Open

This was referenced Jun 16, 2023

Confused and need some help. #50

Open

Google Play Billing v 5.4.0 not availbe #51

Closed

akien-mga mentioned this pull request Oct 31, 2023

Billing library now deprecated/unusable #59

Open

mhilbrunner mentioned this pull request Jan 2, 2024

Update changed signals godotengine/godot-docs#8688

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Google Play Billing Library v5 #36

Google Play Billing Library v5 #36

timoschwarzer commented Sep 1, 2022

timoschwarzer commented Sep 1, 2022

bouncymarble commented Sep 3, 2022

NianoTT commented Sep 4, 2022

bouncymarble commented Sep 5, 2022

NianoTT commented Sep 5, 2022

KoBeWi Jan 15, 2023

KoBeWi Jan 15, 2023

KoBeWi Jan 15, 2023

KoBeWi commented Jan 15, 2023

novalis Feb 13, 2023

novalis Feb 13, 2023

finepointcgi commented May 19, 2023 •

edited

Loading

LettucePie commented May 25, 2023

	subscriptionOfferDetailsDictionary.put("offer_tags", subscriptionOfferDetails.getOfferTags());
	Object[] array = subscriptionOfferDetails.getOfferTags().toArray();
	subscriptionOfferDetailsDictionary.put("offer_tags", array);

	subscriptionOfferDetailsDictionary.put("pricing_phases", pricingPhasesDictionaryList);
	array = pricingPhasesDictionaryList.toArray();
	subscriptionOfferDetailsDictionary.put("pricing_phases", array);

	dictionary.put("subscription_offer_details", subscriptionOfferDetailsDictionaryList);
	Object[] array = subscriptionOfferDetailsDictionaryList.toArray();
	dictionary.put("subscription_offer_details", array);

Google Play Billing Library v5 #36

Are you sure you want to change the base?

Google Play Billing Library v5 #36

Conversation

timoschwarzer commented Sep 1, 2022

timoschwarzer commented Sep 1, 2022

bouncymarble commented Sep 3, 2022

NianoTT commented Sep 4, 2022

bouncymarble commented Sep 5, 2022

NianoTT commented Sep 5, 2022

KoBeWi Jan 15, 2023

Choose a reason for hiding this comment

KoBeWi Jan 15, 2023

Choose a reason for hiding this comment

KoBeWi Jan 15, 2023

Choose a reason for hiding this comment

KoBeWi commented Jan 15, 2023

novalis Feb 13, 2023

Choose a reason for hiding this comment

novalis Feb 13, 2023

Choose a reason for hiding this comment

finepointcgi commented May 19, 2023 • edited Loading

LettucePie commented May 25, 2023

finepointcgi commented May 19, 2023 •

edited

Loading