Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changed signals #8688

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Update changed signals #8688

merged 1 commit into from
Jan 2, 2024

Conversation

flametime
Copy link
Contributor

Old signals in doc does not exist

@AThousandShips
Copy link
Member

You should target master not 4.2, changes can then be cherry picked, see here.

If you need more information about the update process please see: here. If wanted I can fix the branch for you.

@AThousandShips AThousandShips added the needs work Needs additional work by the original author, someone else or in another repo. label Dec 30, 2023
@flametime flametime changed the base branch from 4.2 to master December 30, 2023 17:09
@flametime
Copy link
Contributor Author

Its my first pull request ever, am i do everything correct?

@AThousandShips
Copy link
Member

No you need to fix your branch, see here, it still contains a commit from the wrong branch

@flametime @AThousandShips
Update changed signals
b0cea6d 
Old signals in doc does not exist
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:plugin and removed needs work Needs additional work by the original author, someone else or in another repo. labels Jan 1, 2024
@AThousandShips
Copy link
Member

Fixed the branch for you 🙂

mhilbrunner
mhilbrunner approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, it seems these were changed in godot-sdk-integrations/godot-google-play-billing#36.

@mhilbrunner mhilbrunner merged commit 204754e into godotengine:master Jan 2, 2024
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution! Also thanks to ATS for the branch fix. 🙏

mhilbrunner added a commit that referenced this pull request Jan 25, 2024
@mhilbrunner
Merge pull request #8688 from flametime/patch-1
8e5812d 
Update changed signals
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flametime @AThousandShips @mhilbrunner