Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status): set correct status after checkin #611

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Oct 23, 2024

closes go-vela/community#1016

since check-in can (and does) happen while processing builds, status is getting set to the wrong value. the fix uses the helper function to determine the proper status.

@wass3r wass3r requested a review from a team as a code owner October 23, 2024 02:59
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.02%. Comparing base (3db6801) to head (9ab5ad7).

Files with missing lines Patch % Lines
cmd/vela-worker/register.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   62.07%   62.02%   -0.05%     
==========================================
  Files         121      121              
  Lines        8166     8172       +6     
==========================================
  Hits         5069     5069              
- Misses       2871     2877       +6     
  Partials      226      226              
Files with missing lines Coverage Δ
cmd/vela-worker/register.go 0.00% <0.00%> (ø)

@wass3rw3rk wass3rw3rk merged commit 04b2f56 into main Oct 28, 2024
11 of 13 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/status branch October 28, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

worker is reporting as idle while processing job
4 participants