-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(deployment): use server API types for deployment #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
+ Coverage 53.05% 53.78% +0.72%
==========================================
Files 559 561 +2
Lines 19747 19950 +203
==========================================
+ Hits 10477 10730 +253
+ Misses 8701 8646 -55
- Partials 569 574 +5
|
wass3rw3rk
approved these changes
Sep 30, 2024
plyr4
approved these changes
Oct 1, 2024
timhuynh94
approved these changes
Oct 1, 2024
i would like to see a PR on go-vela/types to annotate the legacy Deployment type as deprecated as we've done with the other types we've moved already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the efforts to migrate from the types repo and also augment API responses.
This should be the last resource that we augment. The rest will stay slim (step, log, etc.)